Yeah! While it's not as high priority because fewer people implement and use it, it would still be great to have :)
On Thu, Apr 15, 2021, 16:16 Mat Arye <[email protected]> wrote: > Thanks to Tom and Julius for the work! > > Would there be interest in a remote_read compliance test as well? If so, > my team would be happy to write it and contribute, but only if people think > it's useful (and it's not already being worked on by others). > > > > On Thu, Apr 15, 2021 at 4:58 AM Julius Volz <[email protected]> wrote: > >> Great, PromLabs is donating its PromQL compliance tester to this effort >> as well: https://github.com/prometheus/compliance/pull/7 >> >> On Wed, Apr 14, 2021 at 1:33 PM Tom Wilkie <[email protected]> wrote: >> >>> SGTM, I've moved it to https://github.com/prometheus/compliance (and >>> moved all the remote_write code to a subdirectory). >>> >>> Cheers >>> >>> Tom >>> >>> On Wed, Apr 14, 2021 at 4:34 AM Callum Styan <[email protected]> >>> wrote: >>> >>>> Repo in prometheus org makes the most sense to me as well. >>>> >>>> On Tue, Apr 13, 2021 at 3:04 PM Julien Pivotto < >>>> [email protected]> wrote: >>>> >>>>> I am in favour of a repo in the prometheus org. >>>>> >>>>> On 13 Apr 22:08, Julius Volz wrote: >>>>> > Nope, they are run as a binary that takes flags, a config, and >>>>> outputs JSON >>>>> > / TEXT / TSV / CSV for consumption by humans / website code / etc. >>>>> > >>>>> > >>>>> https://github.com/promlabs/promql-compliance-tester/blob/master/cmd/promql-compliance-tester/main.go >>>>> > >>>>> > On Tue, Apr 13, 2021 at 9:50 PM Tom Wilkie <[email protected]> >>>>> wrote: >>>>> > >>>>> > > Yeah I’m fine with either - but would probably prefer a single big >>>>> repo. >>>>> > > Are your PromQl tests golang unit tests by any chance? >>>>> > > >>>>> > > On Tue, 13 Apr 2021 at 20:36, Julius Volz <[email protected]> >>>>> wrote: >>>>> > > >>>>> > >> I'm fine with the main org too. Then there's just the question of >>>>> whether >>>>> > >> we have one big compatibility repo for remote_write / PromQL / >>>>> etc., or one >>>>> > >> for each tested interface. There's definitely pros + cons for each >>>>> > >> approach, but I'd ultimately be fine with either I think. >>>>> > >> >>>>> > >> On Tue, Apr 13, 2021 at 6:11 PM Tom Wilkie <[email protected]> >>>>> wrote: >>>>> > >> >>>>> > >>> I only suggested the -community org so its not in my personal >>>>> org, to >>>>> > >>> encourage contributions from the wider community. I would be >>>>> happy to move >>>>> > >>> it to the main prometheus org. >>>>> > >>> >>>>> > >>> As a monorepo guy, I'm less keen on a proliferation of many orgs >>>>> so less >>>>> > >>> keen on a dedicated prometheus-compatibility org... but could >>>>> be convinced. >>>>> > >>> >>>>> > >>> Cheers >>>>> > >>> >>>>> > >>> Tom >>>>> > >>> >>>>> > >>> On Tue, Apr 13, 2021 at 1:48 PM Richard Hartmann < >>>>> > >>> [email protected]> wrote: >>>>> > >>> >>>>> > >>>> On Tue, Apr 13, 2021 at 2:16 PM Julius Volz < >>>>> [email protected]> >>>>> > >>>> wrote: >>>>> > >>>> >>>>> > >>>> > Great! I think as we start taking compatibility more >>>>> seriously, we >>>>> > >>>> could even create a home for remote_write / PromQL / ... >>>>> compatibility >>>>> > >>>> tests in either the main Prometheus org, or in a dedicated >>>>> "Prometheus >>>>> > >>>> Compatibility Project" org? >>>>> > >>>> >>>>> > >>>> I strongly believe that the best place for tests we consider >>>>> official >>>>> > >>>> is the main Prometheus org, as long as the main author is fine >>>>> with >>>>> > >>>> moving them. I do not have strong opinions about the specific >>>>> repo >>>>> > >>>> they live in. >>>>> > >>>> >>>>> > >>> >>>>> > >>>>> > -- >>>>> > You received this message because you are subscribed to the Google >>>>> Groups "Prometheus Developers" group. >>>>> > To unsubscribe from this group and stop receiving emails from it, >>>>> send an email to [email protected]. >>>>> > To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoztaOmqH_wBsF%2BJue9BywkfdO3otQEOxbWVW-P-VeMb6w%40mail.gmail.com >>>>> . >>>>> >>>>> -- >>>>> Julien Pivotto >>>>> @roidelapluie >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Prometheus Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/prometheus-developers/20210413220449.GA1265218%40oxygen >>>>> . >>>>> >>>> -- >> You received this message because you are subscribed to the Google Groups >> "Prometheus Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoxY10RLegTv-va-su1RKbc9TEh%2By0VCSntF_%2BjKSp2AtA%40mail.gmail.com >> <https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoxY10RLegTv-va-su1RKbc9TEh%2By0VCSntF_%2BjKSp2AtA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > Mat Arye, Promscale <https://github.com/timescale/promscale> Team Lead > See what we're working on (feedback welcome!): tsdb.co/prom-design-doc > > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YozQQDgH508Cq%3DrpXe9Z37n-ZpOYpqAZnCnf_Tbd_br-3g%40mail.gmail.com.
