On Mon, Dec 02, 2019 at 09:46:11PM -0000, Christian Weisgerber wrote:
> On 2019-12-01, Marc Espie <es...@nerim.net> wrote:
>
> > This patch:
> > - admits that parallel make is going to be used;
> > - renames PARALLEL_BUILD to something that reflects its actual usage
> > (and consumers as well): PARALLEL_USES_MAKE
> > - adds a PARALLEL_MAKE_JOBS that allows the user to tweak the number
> > of MAKE_JOBS used if they want (set to hw.ncpuonline)
>
> What this actually does: If you set PARALLEL_MAKE_JOBS, then ports
> that are marked DPB_PROPERTIES=parallel will be built with
> MAKE_JOBS=${PARALLEL_MAKE_JOBS} for any regular "make build" outside
> of dpb.
>
> So basically this (ab)uses DPB_PROPERTIES=parallel as a marker for
> ports that are parallel-safe. Okay, whatever.
>
> I think PARALLEL_BUILD is a perfectly fine name and it took me ten
> minutes to understand "PARALLEL_USES_MAKE". I'll probably be puzzled
> again the next time I look at this. Yes, there are a very few ports
> that set PARALLEL_BUILD=No and still do some form of parallel
> building. That's why they have a corresponding comment.
There are no ports that set PARALLEL_BUILD *for any other purpose than
wanting DPB_PROPERTIES=parallel and using something that's NOT make-j
to achieve parallelism*.
Hence my wanting to change the name to reflect reality.
