On Sat Nov 09, 2019 at 07:04:30PM +0100, Klemens Nanni wrote: > On Sat, Nov 02, 2019 at 10:39:26PM +0100, Klemens Nanni wrote: > > On Sat, Nov 02, 2019 at 04:11:50PM -0400, Jon Bernard wrote: > > > I submitted this some time back [1], and here's what I maintain > > > personally [2]. I think the shell completions should be named to match > > > the port to prevent possible collisions. Otherwise it looks good to me. > > Thanks, I did not look into the archives. > > > > jasper's argument of the script not being meant for packaging no longer > > holds true and I consider `pkg_add leiningen' to get a working REPL > > worth adding this port (again). > > > > Good catch on the shell completions, I fixed them to be > > share/bash_completion.d/lein and share/zsh/site-functions/_lein, thanks. > > > > Except for a new PLIST there's nothing else changed in the new tarball. > > OK? > Any opinions, further feedback or OK to import?
If upstream recommends OpenJDK 8, I prefer to set MODJAVA_VER = 1.8 instead of 1.8+ otherwise we run in and error if only JDK11 is installed: $ lein /usr/local/bin/lein: line 122: /usr/local/jdk-1.8.0/bin/java: No such file or directory
