On 2018/04/21 12:53, mazoc...@disroot.org wrote:
> @@ -682,14 +689,12 @@ else()
> set(OTHER_FLAGS "-mthreads -fexceptions")
> endif()
>
> - set(CMAKE_CXX_FLAGS_RELEASE "-DNDEBUG ${RELEASE_WARNING_FLAGS}
> ${WARNING_FLAGS} ${OTHER_FLAGS} -ffast-math -Wall -pipe -funroll-loops")
> + set(CMAKE_CXX_FLAGS_RELEASE "-DNDEBUG ${RELEASE_WARNING_FLAGS}
> ${WARNING_FLAGS} ${OTHER_FLAGS}")
>
> Here is removed -Wall flag (in case your mail client doesn't display
> lines longer than 72 characters, here is formatted version).
Ah got it now... Anyway the reason for removing -Wall varies, sometimes
it's because a port uses -Werror and that causes it to break (maybe just
on some arch or with certain compilers - and maybe it doesn't now but
did in the past), sometimes it's because it gives so many warnings
that important ones are hidden in the noise.
> I've sent other patches to Minetest's developers. I think this port
> will be updated when Minetest 0.4.17 will be released (I tried to port
> 0.4.16, while I don't know C++ I can't fix 0.4.16, I catch abort trap
> when trying enter the world).
Please don't sent patches upstream if they're just to fit in with ports
standards (optimizer levels etc), looking at the patches currently in
the ports tree for minetest the only one which is suitable for feeding
upstream is the ILP32 fix in src/unittest/test_serialization.cpp.
