On Wed Jan 24, 2018 at 12:31:27AM +0100, Klemens Nanni wrote: > > Any objections to import? > Same test results here. I don't use Catch2 but here's an updated port > with the following fixes: > > Drop DISTNAME as it's autogenerated by GH_* and stick to "Catch2" (with > capital C) as that's the project's proper name.
I defiantly prefer lowercase directory and DISTNAME. > > Add missing license version (see http://www.boost.org/users/history/). There is only one boost license and only one version. > > Fixing hardcoded `python' invocations with sed in pre-configure always > seems dirty to me, we have patches and SUBST_CMD for that. But since > all scripts use `#!/usr/bin/env python' as shebang just symlink > MODPY_BIN into PORTPATH here. Your approach is much better, Thanks! > > Python 3 works fine so use that (afaik the policy is to not import > further Python 2 ports). As Python is used for tests only, drop it from > BDEP and RDEP as well. ACK; MODPY_BUILDDEP and MODPY_RUNDEP added. > > Looks good to me otherwise. Thanks for the review! Please find attached a new tarball. ok?
catch2.tar.gz
Description: Binary data
