On 1/23/2018 6:31 PM, Klemens Nanni wrote: > On Thu, Jan 11, 2018 at 10:32:23PM +0100, Rafael Sadowski wrote: >> On Tue Jan 02, 2018 at 10:22:19PM +0100, Rafael Sadowski wrote: >>> Please find attached catch2. >>> >>> https://github.com/catchorg/Catch2 >>> >>> $ pkg/DESCR >>> Catch2 stands for C++ Automated Test Cases in a Header and is a >>> multi-paradigm >>> test framework for C++. which also supports Objective-C (and maybe C). It is >>> primarily distributed as a single header file, although certain extensions >>> may >>> require additional headers. >> New version 2.1.0 attached as a tarball. >> >> Test project /usr/ports/pobj/catch2-2.1.0/build-amd64 >> Start 1: RunTests >> 1/6 Test #1: RunTests ......................... Passed 0.02 sec >> Start 2: ListTests >> 2/6 Test #2: ListTests ........................ Passed 0.01 sec >> Start 3: ListTags >> 3/6 Test #3: ListTags ......................... Passed 0.01 sec >> Start 4: ListReporters >> 4/6 Test #4: ListReporters .................... Passed 0.00 sec >> Start 5: ListTestNamesOnly >> 5/6 Test #5: ListTestNamesOnly ................ Passed 0.01 sec >> Start 6: ApprovalTests >> 6/6 Test #6: ApprovalTests ....................***Failed Error regular >> expression found in output. Regex=[Results differed] 0.68 sec >> >> 83% tests passed, 1 tests failed out of 6 >> >> Any objections to import? > Same test results here. I don't use Catch2 but here's an updated port > with the following fixes: > > Drop DISTNAME as it's autogenerated by GH_* and stick to "Catch2" (with > capital C) as that's the project's proper name.
Why capitalize this, outside of GH_PROJECT? Just to take one random example, Python's proper name is Python and yet it's lowercase in ports/packages. The same is true for thousands of ports, so I don't see why this one needs to be special. There are also no capital letters in pkg/PLIST (catch.hpp and catch.pc, for example). ~Brian > Add missing license version (see http://www.boost.org/users/history/). > > Fixing hardcoded `python' invocations with sed in pre-configure always > seems dirty to me, we have patches and SUBST_CMD for that. But since > all scripts use `#!/usr/bin/env python' as shebang just symlink > MODPY_BIN into PORTPATH here. > > Python 3 works fine so use that (afaik the policy is to not import > further Python 2 ports). As Python is used for tests only, drop it from > BDEP and RDEP as well. > > Looks good to me otherwise.
