On Thu, Aug 24, 2017 at 02:38:47PM +0100, Nigel Taylor wrote: > On the test depends, the run depends includes p5-URI from > p5-HTTP-Message so p5-URI is already present, as testing is in the > rumtime environment, TEST_DEPENDS is for the p5-Test-xxxxxxxx not > normally present at runtime, this ensures TEST_DEPENDS doesn't hide any > missing runtime dependencies.
So you have to know what runtime dependencies p5-HTTP-Message currently has, it may also change with updates there. So instead of checking the tree of dependencies manually, I think it is better to add the test dependencies explicitly. My workflow is to look at Makefile.PL, "use" in the test scripts and skipped output during test run. Then I add everything to test dependencies. Finding run time dependencies by testing does not work unless you always start with empty packages on the machine. And even then it does not gurantee to find everything. I usually look at Makefile.PL and take the run dependencies from there, they are mostly correct. > There is another reason to include run dependencies, for perl ports, and > that's easier maintenance, that the CPAN ports are in fact a dump of a > runtime install, and the configuration checks during the build are for > runtime, and is a verification of the necessary perl ports being present > at runtime. Yes, the CPAN model is different than ours. You get warnings during build, but they are irrelevant if you have correct run dependencies. It was mentioned here https://marc.info/?l=openbsd-ports&m=142221238505036&w=2 and I am quite sure the topic was on the mailing list before. But it is hard to search for that issue. I have no strong opinion here, leave it as it is. bluhm
