On 08/24/17 13:30, Alexander Bluhm wrote:
> On Wed, Aug 23, 2017 at 10:45:48PM +0100, Nigel Taylor wrote:
>> -DISTNAME = HTTP-Cookies-6.01
>> +DISTNAME = HTTP-Cookies-6.04
>
> The Makefile.PL mentions TEST_REQUIRES "URI", you should add a
> TEST_DEPENDS = www/p5-URI.
>
> At one time we decided that BUILD_DEPENDS = ${RUN_DEPENDS} is not
> necessary for most Perl ports. Remove it to make the package build
> more parallel.
>
> otherwise OK bluhm@
>
> bluhm
>
On the test depends, the run depends includes p5-URI from
p5-HTTP-Message so p5-URI is already present, as testing is in the
rumtime environment, TEST_DEPENDS is for the p5-Test-xxxxxxxx not
normally present at runtime, this ensures TEST_DEPENDS doesn't hide any
missing runtime dependencies.
The so called parallel build really doesn't apply, perl ports take so
little time, if anyone wants parallel build then they need to look at
Qt5, libreoffice, etc the large things you want done in parallel, not at
the small things, and remember that runtime's here all came from
p5-libwww when it was split. I don't see dpb builds waiting at the end
for perl ports to complete.
There is another reason to include run dependencies, for perl ports, and
that's easier maintenance, that the CPAN ports are in fact a dump of a
runtime install, and the configuration checks during the build are for
runtime, and is a verification of the necessary perl ports being present
at runtime. The only exception would be to exclude non perl ports
required at runtime only. This also make scanning dpb logs for perl
issues more difficult, with extra warnings generated now have to be
ignored dpb might be a few seconds quicker, but at the cost to
maintainers having to look in detail at the warnings.
I don't agree with either change.
