On Wed, Dec 28, 2016 at 05:52:05PM +0100, Frederic Cambus wrote: > On Wed, Dec 28, 2016 at 09:36:18AM +0100, Sol??ne Rapenne wrote: > > > > Thanks for bringing the issue to upstream. In this case, I suppose we > > > can just run makesum again before importing. > > > > > > Tested the new version with split packages for core and data and it > > > looks good to me, with one caveat though: we should get rid of debug > > > symbols. I noticed they were explicitely added when patching > > > premake4.lua, this should be left out. Is there any specific reason > > > to include them? > > > > > > With this change in, OK fcambus@ to import. > > > > jca@ asked me to enable debug symbols by default because the only way to > > have > > symbols is to use the patch to add it explicitly. If you want to build this > > port > > with debug symbols using DEBUG=-g that won't do anything. > > That makes sense, thanks for clarifying things. > > I think this should go in then, if anyone wants to import. awolk@? >
Imported. Thanks for your work Solene. PS. Please avoid using UTF-8 in port files, including DESCR files. Regards, Adam
