On Tue, Dec 20, 2016 at 12:21:08PM +0100, Solène Rapenne wrote: > Le 2016-12-12 12:42, Frederic Cambus a écrit : > > On Mon, Dec 05, 2016 at 04:14:03PM +0100, Sol??ne Rapenne wrote: > > > > > I'm ok for the MAINTAINER line, my Makefile is in utf-8 so it was > > > supposed > > > to be > > > a "??" character. We can use "e" instead so it works in any case. > > > > > > Latest version in attachment > > > > Tried the port and it works fine. Some suggestions and nitpicking: > > > > 1) If possible, it would be nice to split core and data into two > > different > > packages. This would allow for smaller updates if only core changes > > between versions and data files are left untouched. > > > > You can look at games/openarena and games/neverball for examples on how > > to use subpackages to achieve this. They both have a single DISTFILE > > containing source and data, just like tome. > > > > 2) There is an extra whitespace in the 'do-configure' target before the > > semicolon. > > I splitted in -main and -data like neverball. The game should be able > to run without the -data package if you download a game using the > engine but I added a RUN_DEPENDS because I think most of people will > play ToME when installing tome4.
Hi Solene, while testing the update fcambus@ noticed that the checksum of the downloaded file doesn't match. I was able to confirm the same issue after moving aside my already downloaded distfile from previous tests. Did upstream silently re-roll the 1.4.9 distfile? SHA512 (t-engine4-src-1.4.9.tar.bz2-new) = 0d527f18f9844c38478f71829d4944c3221aa0817f52ab4f44aed5990493a769e206228b367dad413bc9f111be9404db8e9e6b6f9f0e0c821ffc27c721ccc1da SHA512 (t-engine4-src-1.4.9.tar.bz2-old) = f604fe2e65cafb17f173c69f84af292dbd7dd8d74f43947fec3a6ced749d1c1973453ceb2f83e75025a2447b7e0bd6d822801cdfedacffa6680625b4f8ba0999 $ diff -ru t-engine4-src-1.4.9-old t-engine4-src-1.4.9-new/ Binary files t-engine4-src-1.4.9-old/game/engines/te4-1.4.9.teae and t-engine4-src-1.4.9-new/game/engines/te4-1.4.9.teae differ Binary files t-engine4-src-1.4.9-old/game/modules/boot-te4-1.4.9.team and t-engine4-src-1.4.9-new/game/modules/boot-te4-1.4.9.team differ Binary files t-engine4-src-1.4.9-old/game/modules/tome-1.4.9-gfx.team and t-engine4-src-1.4.9-new/game/modules/tome-1.4.9-gfx.team differ Binary files t-engine4-src-1.4.9-old/game/modules/tome-1.4.9-music.team and t-engine4-src-1.4.9-new/game/modules/tome-1.4.9-music.team differ Binary files t-engine4-src-1.4.9-old/game/modules/tome-1.4.9.team and t-engine4-src-1.4.9-new/game/modules/tome-1.4.9.team differ
