On Mon, Dec 05, 2016 at 04:14:03PM +0100, Sol??ne Rapenne wrote:

> I'm ok for the MAINTAINER line, my Makefile is in utf-8 so it was supposed
> to be
> a "??" character. We can use "e" instead so it works in any case.
> 
> Latest version in attachment

Tried the port and it works fine. Some suggestions and nitpicking:

1) If possible, it would be nice to split core and data into two different
packages. This would allow for smaller updates if only core changes
between versions and data files are left untouched.

You can look at games/openarena and games/neverball for examples on how
to use subpackages to achieve this. They both have a single DISTFILE
containing source and data, just like tome.

2) There is an extra whitespace in the 'do-configure' target before the
semicolon.

Reply via email to