On 2016/11/21 10:47, Senthil Kumar M wrote:
> Hi Ports,
> 
> May I request some developer to have a look and commit this port? Earlier, 
> jca made a few changes (attached) and commented that the port looked good. 
> I also tested it once again and it installs, runs as expected.

Generally looks good but a couple of small points:

- An empty share/doc/hmmer/ is installed; it would be useful to
install Userguide.pdf there. Probably also worth installing files
for the tutorial under ${PREFIX}/share/examples/hmmer?

- Zap the blank line at end of pkg/DESCR

- Zap the empty "CONFIGURE_ARGS =" in Makefile

- COPYRIGHT says "HMMER includes patent-pending SIMD technology under
nonexclusive license" - I would draw attention to this in the license
marker comment, e.g.

# GPLv3 but see COPYRIGHT regarding patents

Reply via email to