Hi Sebastien,
Thanks for your work on this. Here's some low hanging fruit.
On Fri, May 20, 2016 at 05:51:54AM +0200, Sebastien Marie wrote:
> Note it requires the pending lang/rust port update.
Which version? BUILD_DEPENDS says it needs lang/rust>=1.8. Or do you
mean it needs your LOCALBASE tweak? If so, the BUILD_DEPEND will need a
bump.
> -sysconfdir=${LOCALBASE}/share/examples/cargo
Usually syconfdir is /etc, and you use @example in the PLIST to make an
example. This also means the user can edit the config file without
upsetting pkg_delete.
> DISTFILES += cargo-bootstrap-${BOOTSTRAP_VERSION}.tar.gz:1
It would be nice to have a target that can make the bootstrap tarball
automatically, like, for example, the lang/pypy does. Is that possible?
And some boring nitpicking:
"cartes.io" -> "crates.io"?
"the package doesn't contains it" -> "the package doesn't *contain* it"
"licencied" -> "licensed"
"licence" -> "license"? (although apparently both are correct. I guess
choose one and stick with it).
"Unlicense" -> "Unlicensed"
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
