On Thu, Sep 24, 2015 at 10:58:43AM -0700, patrick keshishian wrote: > On 9/23/15, Landry Breuil <lan...@rhaalovely.net> wrote: > > On Thu, Sep 24, 2015 at 07:50:15AM +0200, Landry Breuil wrote: > >> On Tue, Sep 22, 2015 at 10:28:37PM -0700, patrick keshishian wrote: > >> > On 9/19/15, Landry Breuil <lan...@rhaalovely.net> wrote: > >> > > On Fri, Sep 18, 2015 at 11:50:19PM -0700, patrick keshishian wrote: > >> > >> On 9/17/15, Landry Breuil <lan...@rhaalovely.net> wrote: > >> > [...] > >> > >> Attached is new tar-ball that compile, but unfortunately "make test" > >> > >> mostly fails[1]. > >> > > > >> > > Yes, but at least it builds :) Lots of ports have failing tests in > >> > > the > >> > > tree.. > >> > > > >> > >> Most failures are due test DB not existing followed by core dump. > >> > > > >> > > Hmm, maybe have a look at databases/postgresql MODULE and the ports > >> > > that > >> > > use it, the module provides helpers to run/create databases for > >> > > testing. > >> > > > >> > >> One hints of bad option. > >> > > > >> > > This one is strange.. > >> > > > >> > >> One on Python module import. > >> > > > >> > > Needs TEST_DEPENDS on databases/py-psycopg2 > >> > > >> > After adding this, the tests which were FAILing change state to > >> > SKIP. The error message relating to their SKIP state, indicated > >> > PG template0 database encoding was ASCII vs expected UTF8. > >> > > >> > Patching databases/postgresql/postgresql.port.mk[1] to accept > >> > an encoding to be specified in port's Makefile. Now more tests > >> > PASS: > >> > > >> > # TOTAL: 18 > >> > # PASS: 6 > >> > # SKIP: 1 > >> > # XFAIL: 0 > >> > # FAIL: 11 > >> > # XPASS: 0 > >> > # ERROR: 0 > >> > > >> > Those which FAIL claim "Out of memory" (see attached test-suite.log). > >> > >> What if you bump ulimit -d ? > > > > Hm, after actually looking at the log, it's coming from the default > > value for --cache. When i tried osm2pgsql locally, with the default it > > was *always* complaining about this so i had to use a lower value. Maybe > > we should patch out in the code the default cache size so that it's more > > system-friendly, instead of forcing the user to specify it.... and it > > would fix the tests :) > > Glad you suggested the patch, I wasn't sure if you'd like that > idea. My own tests work with "-C 300", anything above fails in > different manners; i.e., -C 400 fails more "silently" v -C 500. > I am, however, messing about with small .osm files ATM.
Maybe to be brought upstream, but they probably dont care and like having a greedy-memory behaviour on linux where limits are ... mostly unlimited. Re database encoding, i was meaning that the module could default to create databases using UTFcrap, instead of the default SQL_ASCII we use now. To be tested on the other ports using the module, but i doubt there would be fallout. Vadim ? Landry
