On Thu, Oct 29, 2015 at 08:24:08PM -0700, patrick keshishian wrote:
> On 10/29/15, patrick keshishian <pkesh...@gmail.com> wrote:
> > On 10/29/15, Landry Breuil <lan...@rhaalovely.net> wrote:
> [snip]
> >> Now that postgresql.port.mk allows to run those tests with the correct
> >> charset, can we get an updated tarball with a patch for the default
> >> --cache value (and the corresponding discussion brought upstream) ? I'd
> >> like to import this one this weekend....
> 
> Per request attached is a new tar-ball that takes more tests
> from FAIL to PASS. test-suite.log also attached.

Nice... some nits:

- patches will need comments, the ones fixing %format issues like
  patch-node-ram-cache_cpp need to go upstream in a PR, as
patch-sprompt_cpp and patch-tests_common-pg_cpp
- patch-node-persistent-cache_cpp puzzles me :) a -Werror case ?

I'll try to set cache to 300 directly as a default value inside
osm2pgsql instead of setting it for each and every test, so that by
default it works on OpenBSD with default system limits. I'll also
look into which limits are hit so that it can be documented.

As for the new cmake-based build, since there's been no release with it
yet, that can be worked on later...

Landry

Reply via email to