On Sat, Sep 12, 2015 at 09:05:10AM -0700, patrick keshishian wrote:
> On 9/12/15, Daniel Jakots <vigdis+o...@chown.me> wrote:
> > On Fri, 11 Sep 2015 16:45:31 -0700, patrick keshishian
> > <pkesh...@gmail.com> wrote:
> >
> >> Does the Makefile look better? I think it is headed toward a more
> >> correct direction.
> >
> > Hi,
> >
> > I tried to build it, I had an error, but Patrick quickly sent me a new
> > Makefile (attached), I could build it without problem then. I imported a
> > bunch of osm data in a pgsql database to test, I had the same output
> > that I usually have on Ubuntu so I guess it's good.
> >
> > Thanks for the port!
> >
> > Cheers,
> > Daniel
> 
> Thanks for your test and report Daniel.
> 
> Attached the new tar-ball.

After actually looking into it...

- you have a typo in the patch adding without-lua to configure.ac... but
  since this wasnt a build option provided by upstream, why bother with
adding it and doing a flavor for this? i mean, lua dependency isnt
usually big, and since it provides quite some useful features
(scriptable tag transforming ?) why not enabling it by default ?

- REVISION should be removed, no need to start at 0

- devel/gmake doesnt need to got to BDEP, it's usually done with USE_GMAKE=Yes

- make check fails here:
tests/middle-tests.cpp:7:17: error: tuple: Fichier ou répertoire introuvable
tests/middle-tests.cpp: In function 'int test_node_set(middle_t*)':
tests/middle-tests.cpp:54: warning: comparison between signed and unsigned 
integer expressions
tests/middle-tests.cpp: In function 'int 
test_nodes_comprehensive_set(middle_t*)':
tests/middle-tests.cpp:79: error: 'class expected_nodelist_t' has no member 
named 'emplace_back'

Tried installing libpqxx (as a potential candidate for providing tuple
header) but that didnt help... installing g++ 4.9 didnt help either.
Did you run the tests ?

Landry

Reply via email to