On Wed, Sep 16, 2015 at 11:39:22AM +0200, Ingo Schwarze wrote:
> Hi Ryan,
> 
> Ryan Freeman wrote on Mon, Sep 14, 2015 at 07:26:45PM -0700:
> 
> >  * convert perl -pi -e into sed -i, update expression to suite
> >    this release of chocolate-doom (they added XDG_DATA_* paths,
> >    so this code changed)
> >  * tore hair out because for some reason it seems the autotools 
> >    no-longer respected MAKE_FLAGS execgamesdir setting in the
> >    port Makefile, replaced with another sed -i to update it
> >    directly in src/Makefile.in.  If this isn't necessary, no
> >    idea why MAKE_FLAGS isn't applying..
> 
> Taken.
> 
> >  * remove share/appdata/ and share/icons/ from PLIST as they
> >    are created elsewhere, I believe this is preferred?
> 
> Not taken.  I think these directories are shared items.  Other 
> ports have them, too, when putting files inside.  They are not
> in /etc/mtree/4.4BSD.dist.  You may have gotten away without
> them because you had other ports installed providing them.
> 
> > tested the package out and it loads the game files from
> > /usr/local/share/doom/ as it should, seems to run fine here on
> > amd64.  ports updated before editing this.
> 
> Committed, lest a simple games update turn into a bikeshed...  :)

Clearly, the paint needs to be chocolate-brown... ;)

Thanks for the insights Ingo, and for getting it committed!

Cheers!
--ryan

Reply via email to