Thanks a lot for your changes. They all seem reasonable and help me
understanding how things are done in OpenBSD ports. Looking at existing
ports is not always ideal, as they often seem to do things differently
from how they should be done now.
On Thu, Nov 20, 2014 at 02:43:05AM +0100, Dmitrij D. Czarkoff wrote:
> FWIW on my ThinkPad E325 the performance of mpv is really bad. (MPlayer
> does no good here either, although ffplay copes with everything just
> fine.) I also noticed that it has problems with unmuting if master
> output was muted before mpv started. To really unmute I had to mute
> sound in mpv by pressing "m" and then unmute it by pressing Mute button
> on my keyboard; no other combination worked out.
>
> Although I abuse SUPDISTFILES here, this way it is a bit cleaner and
> allows to use GitHub support in ports infrastructure.
Ah, so that's how you can keep using the GitHub vars with additional
distfiles.
> | -CATEGORIES = x11 multimedia
> | +CATEGORIES = multimedia x11
>
> I am not sure that mpv's primary category should be "x11". I am not
> sure how MPlayer ended up there, but I wouldn't expect mpv at x11/mpv.
I agree. VLC is in x11, too.
> | -BUILD_DEPENDS = textproc/py-docutils
> | +BUILD_DEPENDS = audio/ladspa \
> | + graphics/libmng \
> | + multimedia/libdvdnav>=4.2.0 \
> | + textproc/py-docutils
> |
> | -LIB_DEPENDS = devel/libdvdread>=4.1.0 \
> ...
> | - multimedia/libdvdnav>=4.2.0
> | # Update libbluray to 0.3.0 to --enable-libbluray!
> | -CONFIGURE_ARGS += --enable-sndio \
> | - --enable-dvdnav \
> | +CONFIGURE_ARGS += --disable-optimize \
> | + --disable-dvdnav \
You have disabled libdvdnav and moved it to BUILD_DEPENDS. Was this
intentional?
> Also, I see no reason to avoid ${MODPY_BIN_ADJ} for fixing python
> shebangs. At least the port won't break if convention is changed.
Nope, there probably is none. I just wasn't aware of it ;)
Thanks
- Henrik
