Le 09/11/2012 19:29, Landry Breuil a écrit : > I think you shouldnt even bother commenting the share/examples files, > they can be useful. Other than that, stuart said exactly what i had to > say about the diff. > > On ppc/ati, only composite is auto-enabled, and e produces garbled > colors, the bg/transparent stuff is bright blue, see > http://rhaalovely.net/~landry/shared/e17-openbsd-ppc-shot-2012-11-09_18-49-45.jpg > Probably a littleendian issue. Disabling composite makes it eat a bit > less of cpu time, the about window animation is terribly cpu-hungry. > > On i386/intel, it renders fine, all hw/composite is enabled by default, > and quite cpu-hungry too (80% constant). Disabling composite help a bit. > > Some notes on e itself: > the 1st-run config thing doesnt detect/show any keyboard layout.
Ah yes, it will be fixed upstream. > You can > add one correctly in E with the keymap applet, switching works fine. > The theme list shows 'default'+garbage chars, looks like an unterminated > \0 string. Mmhh, where ?In the settings panel or in the menu ? > shutdown/reboot is greyed out, i suppose it tries to use > consolekit/policykit for that ? No, look at sysactions.conf that you can find probably in /etc. > I didnt see stuff hard crashing; this is pretty nice :) > > All in all this looks pretty good, so with the nits adressed i think you > should commit it, along the eio import. ok for me. > > Landry
