On Fri, Nov 09, 2012 at 09:35:39AM +0000, Stuart Henderson wrote:
> On 2012/11/09 05:29, Stefan Sperling wrote:
> > Before making any more changes I'd like to get this committed if possible.
> > It's a large enough diff already, isn't it?
>
> Yes it is, if test reports are good then I agree with this approach.
>
> A few things I noticed (but I agree with doing this post commit),
> e17/e/Makefile you have this
>
> > FULLARCH = ${MACHINE_ARCH:S/amd64/x86_64/}
> > -SUBST_VARS += FULLARCH OSREV
> > +SUBST_VARS += FULLARCH OSREV VERSION
>
> can you do this for evas too please? (even better would be to patch
> things to not put the OS version in the directory name which means
> that package revisions have to be bumped at release time, but doing
> the easy change first, i.e. adding to SUBST_VARS and regen plist,
> makes sense).
>
> also the share/examples for edge/eet/evas where the whole dir's are
> @commented, probably better to rm -rf them in do-install, you will find
> update-plist fairly annoying when you have a load of commented files.
>
> the whole lot should be marked SHARED_ONLY too (in Makefile.inc
> probably) and roll PFRAG.shared into PLISTs.
I think you shouldnt even bother commenting the share/examples files,
they can be useful. Other than that, stuart said exactly what i had to
say about the diff.
On ppc/ati, only composite is auto-enabled, and e produces garbled
colors, the bg/transparent stuff is bright blue, see
http://rhaalovely.net/~landry/shared/e17-openbsd-ppc-shot-2012-11-09_18-49-45.jpg
Probably a littleendian issue. Disabling composite makes it eat a bit
less of cpu time, the about window animation is terribly cpu-hungry.
On i386/intel, it renders fine, all hw/composite is enabled by default,
and quite cpu-hungry too (80% constant). Disabling composite help a bit.
Some notes on e itself:
the 1st-run config thing doesnt detect/show any keyboard layout. You can
add one correctly in E with the keymap applet, switching works fine.
The theme list shows 'default'+garbage chars, looks like an unterminated
\0 string.
shutdown/reboot is greyed out, i suppose it tries to use
consolekit/policykit for that ?
I didnt see stuff hard crashing; this is pretty nice :)
All in all this looks pretty good, so with the nits adressed i think you
should commit it, along the eio import. ok for me.
Landry
