On 2012/11/09 05:29, Stefan Sperling wrote:
> Before making any more changes I'd like to get this committed if possible.
> It's a large enough diff already, isn't it?
Yes it is, if test reports are good then I agree with this approach.
A few things I noticed (but I agree with doing this post commit),
e17/e/Makefile you have this
> FULLARCH = ${MACHINE_ARCH:S/amd64/x86_64/}
> -SUBST_VARS += FULLARCH OSREV
> +SUBST_VARS += FULLARCH OSREV VERSION
can you do this for evas too please? (even better would be to patch
things to not put the OS version in the directory name which means
that package revisions have to be bumped at release time, but doing
the easy change first, i.e. adding to SUBST_VARS and regen plist,
makes sense).
also the share/examples for edge/eet/evas where the whole dir's are
@commented, probably better to rm -rf them in do-install, you will find
update-plist fairly annoying when you have a load of commented files.
the whole lot should be marked SHARED_ONLY too (in Makefile.inc
probably) and roll PFRAG.shared into PLISTs.
