On Mon, May 23, 2011 at 09:36:40AM +0200, Jasper Lievisse Adriaanse wrote:
> On Sat, May 21, 2011 at 05:46:55PM -0700, Ryan Freeman wrote:
> > On Sat, May 21, 2011 at 06:12:31PM -0400, Brynet wrote:
> > > Cool, thanks for looking at this Ryan and Antti for sending it to him, my 
> > > patches made revision 1879-1881 so anything newer than that is cool.
> > > 
> > > They rejected my change for OpenGL support though, this project dlopen's 
> > > libGL.so.1 and libGLU.so.1.
> > > 
> > > The following patch is needed for that, other things that might be worth 
> > > fixing 
> > > is the GTK+ frontend, and POLYMER. I think NEDMALLOC can be avoided.
> > > 
> > > Good luck,
> > > -Bryan.
> > > 
> > 
> > Thanks, I've added that patch in. I also made additions to astub.c and 
> > game.c
> > for addsearchdir to check /usr/local/share/games/duke3d which makes the
> > shareware data pulled in with several of Antti's other Makefile entries.
> > 
> > I'm not entirely sure if including shareware data with the port is a good
> > idea though, and perhaps it would be best served by a seperate 
> > games/duke3ddata port akin to the current games/doomdata. thoughts?
> > 
> > attached is an updated version of my port with heavy influence from
> > Antti's Makefile, thanks ;)
> > 
> > all original patches outside of the libGL changes Bryan sent me have been
> > removed as Bryan's original patches have been merged upstream. 
> > 
> > Come get some.
> > 
> > -ryan
> 
> Hi,
> 
> Some quick feedback:
> - it's lacking devel/nasm as a build dependency (on at least i386)
> - it does honor CFLAGS, but not CC.

see attached for updated port. I've added BUILD_DEPENDS on devel/nasm
for the i386 target, and I think I've squashed the CC issue (thanks
Jasper! :) Additionally after discussion on the above regarding data
file placement, I have modified my initial changes and the port now
respects data located in ${LOCALBASE}/share/duke3d. Shareware data is
installed to this spot. Comments?

-ryan

> 
> Jasper
> 
> "Capable, generous men do not create victims, they nurture them."

Attachment: eduke32.tgz
Description: application/tar-gz

Reply via email to