Comment with C is get from freebsd port comment. After last mail from persg...@gmail.com changed to C++. But if look some strcpy statements found they above allocated memory for destination string without room for zero byte.
Ok, when you want this port I will fix Makefile spaces and other things from your wishlist. On Tue, 25 Jan 2011 10:19:33 +0000 Stuart Henderson <s...@spacehopper.org> wrote: > On 2011/01/25 11:51, Michael Pounov wrote: > > Hi, > > that is port version with patches for warnings who replaced with > > strlcpy and strlcat. Fixed few buffer overflows in allocated buffers > > and change in DESCR file C -> C++. > > Ports is locked for release engineering now, but here are a > few things to work on: > > With a few rare exceptions (e.g. commonly used libraries) we > don't do strcpy->strlcpy in ports patches any more, it makes it > difficult to reliably update, so please work with upstream on > getting these committed (I imagine they will need a strlcpy > wrapper for OS where it's not available natively) > > I would remove the details about the programming language > from COMMENT as it's not really relevant here, also make the > whitespace more consistent (you mostly have 'FOO=bar' but > one 'FOO = bar'), > > The WRKDIST line should be removed as it's set to the default > > The license comment also needs to have the version number > recorded (but it's not clear which applies as the source code > files do not contain clear copyright notices with license > details, there is just a bunch of files some with copyright > with no license details, and a COPYING file present in the > tar.gz, so this is something upstream would need to tidy). > -- Best Regards, Michael Pounov <mi...@elwix.org> ---------------------------------------------- ELWIX - Embedded LightWeight UNIX Universal multiplatform embedded OS
