On 2011/01/25 11:51, Michael Pounov wrote: > Hi, > that is port version with patches for warnings who replaced with > strlcpy and strlcat. Fixed few buffer overflows in allocated buffers > and change in DESCR file C -> C++.
Ports is locked for release engineering now, but here are a few things to work on: With a few rare exceptions (e.g. commonly used libraries) we don't do strcpy->strlcpy in ports patches any more, it makes it difficult to reliably update, so please work with upstream on getting these committed (I imagine they will need a strlcpy wrapper for OS where it's not available natively) I would remove the details about the programming language from COMMENT as it's not really relevant here, also make the whitespace more consistent (you mostly have 'FOO=bar' but one 'FOO = bar'), The WRKDIST line should be removed as it's set to the default The license comment also needs to have the version number recorded (but it's not clear which applies as the source code files do not contain clear copyright notices with license details, there is just a bunch of files some with copyright with no license details, and a COPYING file present in the tar.gz, so this is something upstream would need to tidy).
