On Sun, Oct 31, 2010 at 11:40:38PM +0000, Christian Weisgerber wrote: > Jacob Meuser <jake...@sdf.lonestar.org> wrote: > > > > CONFIGURE_ARGS+= --disable-mp3lib --enable-mpg123 > > > LIB_DEPENDS+= ::audio/mpg123 > > > WANTLIB+= mpg123 > > > > doesn't that produce a symbol mismatch warning between libmp3lame and > > libmpg123? > > I don't see this on amd64.
I need to recheck this, as I did see this at p2k10. > > I was noticing that at p2k10, which is why --disable-mpg123 > > is being used. > > We should try to keep the external dependencies at a minimum. We > have four MP3 decoders, in order of default preference: > > mp3 mp3lib internal floating point > mpg123 mpg123 external floating point/integer > ffmp3float ffmpeg internal floating point > ffmp3 ffmpeg internal integer > > With the exception of ffmp3float, which doesn't work at all with > sndio, any of these will do. The only restriction is that you want > an integer decoder on arm machines, ergo: > > non-arm arm > mp3 on off > mpg123 off off > ffmp3float off off > ffmp3 on on The above comment should go into the Makefile for reference. > It is annoying that he have to revisit this same mess every frigging > time mplayer is updated. Tell me about it. To add to this, I have found that mencoder is not really maintained anymore. This leads me to think that we should disable it and tell user's to use ffmpeg for encoding. But I bet someone is using mencoder... -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
