Jacob Meuser <jake...@sdf.lonestar.org> wrote:
> > CONFIGURE_ARGS+= --disable-mp3lib --enable-mpg123
> > LIB_DEPENDS+= ::audio/mpg123
> > WANTLIB+= mpg123
>
> doesn't that produce a symbol mismatch warning between libmp3lame and
> libmpg123?
I don't see this on amd64.
> I was noticing that at p2k10, which is why --disable-mpg123
> is being used.
We should try to keep the external dependencies at a minimum. We
have four MP3 decoders, in order of default preference:
mp3 mp3lib internal floating point
mpg123 mpg123 external floating point/integer
ffmp3float ffmpeg internal floating point
ffmp3 ffmpeg internal integer
With the exception of ffmp3float, which doesn't work at all with
sndio, any of these will do. The only restriction is that you want
an integer decoder on arm machines, ergo:
non-arm arm
mp3 on off
mpg123 off off
ffmp3float off off
ffmp3 on on
I guess we could disable mp3 everywhere, but then ffmp3 is a bit
chatty (see song30.mp3 and song32.mp3) and the mplayer people still
think that mp3 is somewhat preferable.
It is annoying that he have to revisit this same mess every frigging
time mplayer is updated.
--
Christian "naddy" Weisgerber na...@mips.inka.de
