Edd Barrett <vex...@gmail.com> wrote:

> Mplayer update. Now we can play webm (vpx) files. Requires the x264 update.
> Tested i386, amd64, sparc64 and PPC.
> 
> Did I miss anything?

(1)
This port is in dire need of comments.  The --disable options should
probably be sorted into two groups, one that disables internal
components and one that prevents external libraries from being
picked up.  At least some options should have comments WHY they are
set, because otherwise nobody will remember and it will be impossible
to check at the next update if the reasons are still applicable.

If you find that hard because you're not sure what all the options
do, you are proving my point.  What exactly was the vorbis/tremor
problem...?

I had to look into the configure script to see that --disable-mpg123
keeps an external libmpg123 from being picked up and is thus very
different from --disable-mp3lib.

(2)
There is no point in depending on the old external libdca for
decoding DTS.  The included ffdca decoder is an improved descendant
and works fine.  Tested with the DTS track of a DVD.  ("DCA" is
just a stupid code name because "DTS" is a trademark.)

(3)
The ffmpeg subdirectory builds with "silent rules", so you don't
see the actual compiler commands.  This misfeature can be disabled
by setting a variable V in the environment.


--- Makefile.orig       Thu Oct 28 11:03:58 2010
+++ Makefile    Thu Oct 28 12:27:08 2010
@@ -25,7 +25,7 @@
 PERMIT_PACKAGE_FTP=    Yes
 PERMIT_DISTFILES_CDROM=        Yes
 PERMIT_DISTFILES_FTP=  Yes
-WANTLIB=               a52 bz2 c cdda_interface cdda_paranoia crypto dca \
+WANTLIB=               a52 bz2 c cdda_interface cdda_paranoia crypto \
                        dv dvdnavmini dvdread faac faad fribidi jpeg lcms \
                        m mng mp3lame mpcdec ncurses ogg.>=5 orc-0.4 png \
                        pthread schroedinger-1.0 sndio speex stdc++ theora \
@@ -56,7 +56,6 @@
                ::devel/fribidi \
                ::graphics/lcms \
                ::graphics/libmng \
-               ::audio/libdca \
                ::archivers/bzip2 \
                ::multimedia/schroedinger \
                ::audio/faad \
@@ -81,6 +80,7 @@
 
 USE_GMAKE=     Yes
 USE_GROFF =    Yes
+MAKE_ENV=      V=1     # disable silent rules in ffmpeg directory
 CONFIGURE_STYLE=simple
 CONFIGURE_ARGS+=--disable-alsa \
                --disable-arts \
@@ -97,6 +97,7 @@
                --disable-libvorbis \
                --disable-tremor \
                --disable-mad \
+               --disable-libdca \
                --disable-libcdio \
                --disable-toolame \
                --disable-dvdread-internal \
-- 
Christian "naddy" Weisgerber                          na...@mips.inka.de

Reply via email to