On Wed, Aug 26, 2009 at 08:16:34PM +0100, Edd Barrett wrote:

> +WANTLIB=             c crypto m ncurses oil-0.3 pthread stdc++ util sndio \
> +                     z pthread-stubs xcb

shouldn't pthread-stubs and xcb be part of the !no_x11 wantlibs?

> +             --enable-faac \
> +CONFIGURE_ENV+=      LDFLAGS="-lfaac"

are you sure this is needed after fixing the configure check?

>  post-patch:
> -     @cp ${FILESDIR}/ao_rtunes.c ${FILESDIR}/ao_libsndio.c ${WRKSRC}/libao2
> +     @cp ${FILESDIR}/ao_rtunes.c ${FILESDIR}/ao_sndio.c ${WRKSRC}/libao2
> +     @cp ${FILESDIR}/ai_sndio.c ${WRKSRC}/stream

is anyone able to record from a video(4) device with mencoder?
it doesn't work for me, and that's currently the only way to
test ai_sndio ...

> +post-build:
> +     @cd ${WRKSRC}/DOCS/xml && ${MAKE_PROGRAM}

this builds both a single html page and split pages for
the docs.  do we really need both?

> +--- DOCS/xml/configure.orig  Tue May 12 19:58:57 2009
> ++++ DOCS/xml/configure       Fri Jul 10 10:48:16 2009
> +@@ -18,7 +18,8 @@ for _try_catalog in \
> +   /usr/lib/sgml/catalog \
> +   /usr/local/lib/sgml/catalog \
> +   /usr/share/docbook-xml42/catalog.xml \
> +-  /usr/share/sgml/docbook/xmlcatalog
> ++  /usr/share/sgml/docbook/xmlcatalog \
> ++  /usr/local/share/sgml/catalog
> + do
> +   if test -f "$_try_catalog"
> +   then
> +@@ -49,6 +50,7 @@ for _try_chunk_xsl in \
> +   /usr/share/sgml/docbook/xsl-stylesheets*/html/chunk.xsl \
> +   /usr/share/xml/docbook/stylesheet/nwalsh/current/html/chunk.xsl \
> +   /opt/local/share/xsl/docbook-xsl/html/chunk.xsl \
> ++  /usr/local/share/xsl/docbook/html/chunk.xsl
> + 
> + do
> +   if test -f "$_try_chunk_xsl"
> +@@ -78,6 +80,7 @@ for _try_docbook_xsl in \
> +   /usr/share/sgml/docbook/xsl-stylesheets*/html/docbook.xsl \
> +   /usr/share/xml/docbook/stylesheet/nwalsh/current/html/docbook.xsl \
> +   /opt/local/share/xsl/docbook-xsl/html/docbook.xsl \
> ++  /usr/local/share/xsl/docbook/html/docbook.xsl
> + 
> + do
> +   if test -f "$_try_docbook_xsl"
> +@@ -135,7 +138,8 @@ for _try_dtd in \
> +   /usr/share/sgml/docbook/dtd/xml/*/docbookx.dtd \
> +   /usr/share/docbook-xml*/docbookx.dtd \
> +   /opt/local/share/xml/docbook*/*/docbookx.dtd \
> +-  /usr/share/apps/ksgmltools2/docbook/*/docbookx.dtd
> ++  /usr/share/apps/ksgmltools2/docbook/*/docbookx.dtd \
> ++  /usr/local/share/xml/docbook/*/docbookx.dtd

these need to not have /usr/local hardcoded.

> +   for _ld_faac in "-lfaac" "-lfaac -lmp4v2 -lstdc++" ; do
> +-    cc_check -O4 $_ld_faac $_ld_lm && libs_mencoder="$libs_mencoder 
> $_ld_faac" && _faac=yes && break
> ++    cc_check -O2 $_ld_faac $_ld_lm && libs_mencoder="$libs_mencoder 
> $_ld_faac" && _faac=yes && break

you should really just remove the -O4, not add -O2 in it's place.

> +    XShmAttach( wsDisplay,&win->Shminfo );
> ++   XSync(wsDisplay, False);

minor nit: the rest of the code uses foo( bar ) style spacing.

> +$OpenBSD$
> +--- stream/tvi_bsdbt848.c.orig       Tue May 12 19:58:57 2009
> ++++ stream/tvi_bsdbt848.c    Sat Jul 11 06:45:32 2009

did anyone test recording from a bktr(4)?  this "driver" should be
really converted to using the new ai streams framework ...

> --- mplayer.cvs/pkg/PFRAG.no-no_x11   Sun Aug 23 23:46:43 2009
> +++ mplayer/pkg/PFRAG.no-no_x11       Sun Aug 23 15:42:40 2009
> @@ -1,39 +1,58 @@
>  @comment $OpenBSD: PFRAG.no-no_x11,v 1.6 2006/07/19 21:40:47 robert Exp $
> -bin/gmplayer
> -share/applications/
> +...@comment bin/gmplayer

you should remove the @comment for gmplayer.  I accidently left that
in a patch I had sent.

-- 
jake...@sdf.lonestar.org
SDF Public Access UNIX System - http://sdf.lonestar.org

Reply via email to