On Wed, Aug 26, 2009 at 08:16:34PM +0100, Edd Barrett wrote:
> On Tue, Aug 25, 2009 at 08:49:22AM +0100, Edd Barrett wrote:
> > I forgot to diff -r this patch, will regenerate later tonight. Sorry
> > for any inconvenience.
> 
>  * generate patch with -r
>  * patch -O4 to -O2 in configure

what did you do, use sed?

you've patched stuff that only affects OS X and separately
changed -O4 to -O2 but left $_march $_mcpu immediately after ...

> +-    CFLAGS="-Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 $_march 
> $_mcpu $_pipe -ffast-math -fomit-frame-pointer"
> ++    CFLAGS="-Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O2 $_march 
> $_mcpu $_pipe -ffast-math -fomit-frame-pointer"
> +     extra_ldflags="$extra_ldflags -ffast-math"


but the above is only used if CFLAGS is empty.  since CFLAGS
is not empty by default, I never bothered with this.  should
these CFLAGS be sanitized anyway?

-- 
jake...@sdf.lonestar.org
SDF Public Access UNIX System - http://sdf.lonestar.org

Reply via email to