On 24-06-07 15:34:38, Kirill A. Korinsky wrote: > On Fri, 07 Jun 2024 12:11:44 +0100, > Stuart Henderson <s...@spacehopper.org> wrote: > > > > On 2024/06/07 01:04, Kirill A. Korinsky wrote: > > > I also included trivial patches to add missed syscall.EBADMSG on 386, > > > amd64 > > > and arm which allows to remove dozen of patches from port tree. > > > > slight exaggeration... 7 patches in docker-compose and 7 in > > docker-buildx, all because of github.com/tonistiigi/fsutil. > > > > just a bit, but it it still dozen of patches. > > > afaik they're meant to be getting these from golang.org/x/sys/unix > > (where EBADMSG *is* present for all OpenBSD platforms) rather than > > go itself anyway? > > I've already tried it and discovered an issue that x/sys/unix isn't > available on windows that is expected, but syscall.EBADMSG is available on > windows. My approach to replace it in fsutil fails on CI [1].
syscall.EBADMSG is one of the few cases where it still makes sense to use the syscall package (since it is - or should be - abstracted and available for all GOOS/GOARCH).
