On Fri, 07 Jun 2024 12:11:44 +0100, Stuart Henderson <s...@spacehopper.org> wrote: > > On 2024/06/07 01:04, Kirill A. Korinsky wrote: > > I also included trivial patches to add missed syscall.EBADMSG on 386, amd64 > > and arm which allows to remove dozen of patches from port tree. > > slight exaggeration... 7 patches in docker-compose and 7 in > docker-buildx, all because of github.com/tonistiigi/fsutil. >
just a bit, but it it still dozen of patches. > afaik they're meant to be getting these from golang.org/x/sys/unix > (where EBADMSG *is* present for all OpenBSD platforms) rather than > go itself anyway? I've already tried it and discovered an issue that x/sys/unix isn't available on windows that is expected, but syscall.EBADMSG is available on windows. My approach to replace it in fsutil fails on CI [1]. As far as I know go hasn't got condition compiling that allows to inclide or exclude some block of code inside file and the only way is making dedicated files which is used at some platforms, that means quite a work to refactor fsutil to move away from syscall to x/sys. Footnotes: [1] https://github.com/catap/fsutil/commit/aa976fb00b3a25d23bacb193c5dfcf13d7db7199#diff-d1445ba8bd61e8e9f66950832df5b1d76f222e7f1f38700a30b728c214da04ccL126-L129 -- wbr, Kirill
