Hi, I would need a clarification:
The correct way to compile the
current megacmd.tar.gz is
dowloading the -stable, not -current.
Am I right?
Il giorno gio 15 giu 2023 alle 18:17 Robert Bagdan <kikadf...@gmail.com> ha
scritto:
> Thanks to your reviews, I will install -current OpenBSD to a vm in the
> next few days, and fix this port with your modifications and
> proposals.
> I will come back soon.
>
> Stuart Henderson <s...@spacehopper.org> ezt írta (időpont: 2023. jún.
> 15., Cs, 9:24):
> >
> > On 2023/06/14 13:13, Omar Polo wrote:
> >
> > > the patches seemed fine for me. I'd wish we could avoid patching for
> > > ereadline.
> >
> > that's normal for our renamed ports version of readline.
> >
> > > The only odd one is patches/patch-sdk_include_mega_http_h which
> > > defines AI_V4MAPPED...
> >
> > sdk/include/mega/http.h
> > 44-
> > 45-#if defined(__FreeBSD__) || defined(__OpenBSD__)
> > 46-#include <netinet/in.h>
> > 47:#define AI_V4MAPPED 0x00000800
> > 48-#endif
> > 49-
> > 50-namespace mega {
> >
> > yes, don't set it to some random value
> >
> > sdk/src/http.cpp
> > 270- hints.ai_family = AF_UNSPEC;
> > 271-
> > 272-#ifndef __MINGW32__
> > 273: hints.ai_flags = AI_V4MAPPED | AI_ADDRCONFIG;
> > 274-#endif
> > 275-
> > 276- if (!getaddrinfo("ns.mega.co.nz", NULL, &hints, &aiList))
> >
> > since it's only used in this one place, best bet is to remoce the http.h
> > patch and remove AI_V4MAPPED from http.cpp.
> >
> > (if it was used more often, I'd define it, but to 0).
> >
> >
> > > - the bundled sdk installs also the headers, a static library and a
> > > pkgconfig file:
> > >
> > > 1. we usually prefer dynamic linking
> > > 2. would it make sense (maybe in the future) to split the sdk off
> > > this port? There are other projects we may want that need
> > > this sdk too? Maybe there's already something in ports that
> > > optionally looks for this and could statically link to
> > > libmega?
> >
> > I think I would have used a separate port for the sdk, but think this
> > way is ok too (especially if nothing else uses the sdk).
> >
> > > - i'd probably install the bash completions in
> > > /usr/local/share/bash-completion and avoid to @sample, but I don't
> > > use bash and don't really know the difference (if there is) to
> > > install in /etc/bash_completion.d.
> >
> > yes, please use /usr/local/share/bash-completion like other ports do.
> >
> > "MEGAcmd provides non UI access to MEGA services"
> >
> > I see this is just copied from the readme, but "non UI" doesn't make
> > much sense. Something like "MEGAcmd provides scriptable command-line
> > tools and an interactive shell to access services from mega.nz"?
> >
>
>
> --
> kikadf
>
>
