On 2023/06/20 17:00:22 +0100, Stuart Henderson <s...@spacehopper.org> wrote:
> On 2023/06/20 17:19, Robert Bagdan wrote:
> > I updated megacmd files with your mentions:
> >
> > 1) Sorted the variables as per Makefile.template
> > 2) Renamed the sdk distname
> > 3) Set DISTFILES once
>
> btw ${GH_DISTFILE} is preferred over ${DISTNAME}${EXTRACT_SUFX},
> that way it also does the right thing if you change to test
> something downloaded by commit hash (GH_COMMIT) rather than tag
+1
> > 4) I don't add bash as RUN_DEPENDS because it isn't need to use
> > megacmd, works well with other shells, I use with the default ksh
it's the right thing actually. Sorry, my proposal to add bash as RDEP
was wrong.
(although it could be a good idea to upstream the /bin/bash -> /bin/sh
change as nothing in those one-liners requires bash)
> > 5) gtest to TEST_DEPENDS
> > 6) Splitted and sorted CONFIGURE_ARGS
> > 7) Consistently use of variable declarations
> > 8) Fix PLIST
> > 9) Remove AI_V4MAPPED from http.cpp, and fix http.h patch to not declare
> > that
> > 10) Use shared libs (I forgot why I used the static library…)
> > 11) I don't split the sdk library, as use this only megacmd and not
> > possible to set the sdk libs as external dependency in configure
> > script of megacmd
> > 12) patching megacmd to use the default bash-completion path
> > 13) Change DESCR
> >
> > I built and tested on -current, works for me.
>
> I don't have an account to test runtime, but this is looking much
> better to me now.
same for me.
can replicate the linking failure, but haven't looked into it.
Thanks,
Omar Polo
