On 2023/01/04 16:48:05 +0900, SASANO Takayoshi <u...@mx5.nisiq.net> wrote:
> Hello,
>
> - patch for configure.ac is simplified by your idea.
> (new diff is also posted to github)
thanks!
> - warning of pcm.c is fixed, but I use (long)status->xxxxx.tv_sec cast
> because of other printf() uses same thing. no %ld -> %lld format change.
generally speaking I'm not sure this is fine. time_t is 64 bit long
here. However, it matches what upstream already do (albeit should
change) and seems to be used only for logging, so maybe it's fine.
> - add comment before NO_TEST
Ooops, sorry, yesterday I failed to notice that SHARED_LIBS should
start at zero for new ports:
SHARED_LIBS = asound 0.0 # 2.0
SHARED_LIBS += atopology 0.0 # 2.0
> ok?
with that fixed the port looks fine to me, and builds fine too. What
I don't know is how it's supposed to be used. Is it needed to port
something else?
Thanks,
Omar Polo
