On 2022/02/03 17:56, Volker Schlecht wrote:
> I've included another patch nicked from www/chromium that looks like it
> addresses this issue. I had no way of testing i386, so I didn't just blindly
> include it at first.
> 
> Note: www/chromium includes another ia32 patch, that's not needed in
> lang/node and probably in www/chromium anymore:
> 
> patch-v8_src_compiler_backend_ia32_instruction-selector-ia32_cc
> --> That was fixed upstream with
> https://github.com/v8/v8/commit/6b2e9f6407fcb0b688f2cbdcda06e2286e84633b

Thanks, trying that now.

> The other patch should fix builds breaking on machines with devel/gtest
> installed from ports. In those cases, node picked up and used the (ancient)
> ports version, instead of the bundled one.

that one fails on a system without gtest installed:

  c++ -o 
/pobj/node-16.13.2/node-v16.13.2/out/Release/obj.target/libnode/src/js_stream.o 
../src/js_stream.cc '-DV8_DEPRECATION_WARNINGS' 
'-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' 
'-D__STDC_FORMAT_MACROS' '-DNODE_ARCH="ia32"' '-DNODE_PLATFORM="openbsd"' 
'-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' 
'-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-D__POSIX__' 
'-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DHAVE_OPENSSL=1' 
'-DOPENSSL_API_COMPAT=0x10000000L' -I/usr/local/include 
-I/usr/local/include/eopenssl11 -I../src 
-I/pobj/node-16.13.2/node-v16.13.2/out/Release/obj/gen 
-I/pobj/node-16.13.2/node-v16.13.2/out/Release/obj/gen/include -I/pobj/node-
16.13.2/node-v16.13.2/out/Release/obj/gen/src -I../deps/histogram/src 
-I../deps/uvwasi/include -I../deps/v8/include -I
../deps/llhttp/include  -Wall -Wextra -Wno-unused-parameter -pthread -Wall 
-Wextra -Wno-unused-parameter -m32 -I/usr/l
ocal/include -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++14 
-MMD -MF /pobj/node-16.13.2/node-v16.1
3.2/out/Release/.deps//pobj/node-16.13.2/node-v16.13.2/out/Release/obj.target/libnode/src/js_stream.o.d.raw
  -O2 -pipe
   -c
In file included from ../src/js_native_api_v8.cc:6:
In file included from ../src/js_native_api_v8.h:7:
../src/js_native_api_v8_internals.h:19:10: fatal error: 'gtest/gtest_prod.h' 
file not found
#include "gtest/gtest_prod.h" 
         ^~~~~~~~~~~~~~~~~~~~ 
1 error generated.
gmake[1]: *** [libnode.target.mk:341: 
/pobj/node-16.13.2/node-v16.13.2/out/Release/obj.target/libnode/src/js_native_ap
i_v8.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....

Reply via email to