On 2022/01/26 08:12, Volker Schlecht wrote:
> At the risk of being considered a PITA: Is there anything *I* can do to
> move this a step forward?
I can only speak for myself and there are other people that can
review too, but I already mentioned what would have made it easier for
me to review on the ghostscript thread,
: reformatting the whole makefile in an update (especially for a complex
: port) makes it really hard to see what's changed, making review more
: difficult and take longer
Cut the size of the diff and you make it easier to review (and easier
for anyone trying to figure out what exactly was changed in an update
when looking at commit history).
Take this for example
-DISTFILES = node-pledge-{}${PLEDGE_VER}.tar.gz:0 \ -
${DISTNAME}-headers.tar.gz \ -
${DISTNAME}.tar.gz
-
-DISTNAME = node-${NODE_VERSION}
-PKGNAME = ${DISTNAME:S/v//g}
-REVISION = 0
+DISTFILES = ${DISTNAME}${EXTRACT_SUFX}
+DISTFILES += ${DISTNAME}-headers${EXTRACT_SUFX}
+DISTFILES += node-pledge-{}${PLEDGE_VER}.tar.gz:0
+
+DISTNAME = node-${NODE_VERSION}
+PKGNAME = ${DISTNAME:S/v//g}
The following one line has the same effect
-REVISION = 0
The rest is just a lot of extra cognitive load when reviewing,
and it's like this all through the diff. Like changing from the
existing
LIB_DEPENDS = ... \
... \
to
LIB_DEPENDS += ...
LIB_DEPENDS += ...
So everything has to be read together rather than just working through
the diff in order.
(incidentally with the LIB_DEPENDS, what's there now is what's normally
used in the ports tree for hand-written continuation lines; it's not
"wrong" with += on each line, but this change moves the port further
from what "a normal port" looks like.)
Overall effect is that it's going to take probably half an hour+ just
to figure out what the actual changes are before looking at them.
Meaning that it takes a bigger chunk of free time in order for it to
be possible to start on it. And if that sort of chunk of time is
available then frankly there are more useful things to do with it than
figuring out which are noop changes and which are real..
I will get to it if nobody beats me to it but it may take a few days yet.
