On 2021/12/15 20:34, Klemens Nanni wrote: > On Wed, Dec 15, 2021 at 09:21:59PM +0100, Stefan Hagen wrote: > > Klemens Nanni wrote: > > > This port is required for another upcoming port. > > > rnnoise is small and standalone and already works when used in that port > > > so I'd like to get it in now as a first step. > > > > > > I'll maintain the package. > > > > > > --- > > > Information for inst:rnnoise-20210312 > > > > > > Comment: > > > Recurrent neural network for audio noise reduction > > > > > > Description: > > > RNNoise is a noise suppression library based on a recurrent neural > > > network. > > > A description of the algorithm is provided in the following paper: > > > > > > J.-M. Valin, A Hybrid DSP/Deep Learning Approach to Real-Time Full-Band > > > Speech > > > Enhancement, Proceedings of IEEE Multimedia Signal Processing (MMSP) > > > Workshop, > > > arXiv:1709.08243, 2018. > > > https://arxiv.org/pdf/1709.08243.pdf > > > > > > While it is meant to be used as a library, a simple command-line tool is > > > provided as an example. It operates on RAW 16-bit (machine endian) mono > > > PCM files sampled at 48 kHz. > > > > > > Maintainer: Klemens Nanni <[email protected]> > > > > > > WWW: https://jmvalin.ca/demo/rnnoise > > > --- > > > > > > Feedback? OK? > > > > Nice one. > > > > * Space in the $OpenBSD$ marker (portcheck -N complains) > > * COMMENT should start lowercase > > /me should really use portcheck more often... > > > If you write in pkg/DESCR that a command line tools is available, you > > should probably install it. I assume examples/rnnoise_demo.c is meant. > > > > Version attached with the above fixed and pkg slightly adjusted to make > > clear that the command line tool is provided as code. > > Thanks for that, OK with using EXAMPLESDIR like this on top? > > EXAMPLESDIR = ${PREFIX}/share/examples/rnnoise > > post-install: > ${INSTALL_DATA_DIR} ${EXAMPLESDIR} > ${INSTALL_DATA} ${WRKSRC}/examples/rnnoise_demo.c ${EXAMPLESDIR}/ >
If DESCR says a command line tool is available, why not compile it rather than just leave the source code in examples/? Normal standard in ports is to not use NO_TEST unless there's an actual failure when you "make test". (most autoconf things are like that). That way if a test is added later it gets picked up without having to remember to remove the line.
