drosca added inline comments.

INLINE COMMENTS

> pino wrote in gsettingsitem.cpp:42
> As I said, to better not silently miss new types of keys, as logging to 
> terminal will not help with a GUI application.

Sure, but qFatal here will take down the whole plasmashell and effectively 
break the login to desktop session.

Also, this should only be reached by developer when trying to read new key as 
type of existing keys should not change (and it already supports all types that 
are currently used in code).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: pino, lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to