davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> OsdSelector.qml:107
> +                        } else {
> +                            checked = false
> +                        }

Given we're doing this manually, we should drop the ButtonRow which is also 
meddling with what's checked or not.

Row should be a drop in replacement.

> OsdSelector.qml:162
> +            if (event.key === Qt.Key_Right) {
> +                event.accepted = true
> +                next()

why do you accept right, but not left?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14165

To: gladhorn, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to