hein marked 5 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> graesslin wrote in launchertasksmodel.cpp:134
> nitpick: added newline
Intentional - my style tends to involve a lot of whitespace I guess (I
personally find it more readable when browsing code).
> graesslin wrote in tasktools.cpp:145
> QLatin1String
Done.
> graesslin wrote in xwindowtasksmodel.cpp:984
> this looks like an unrelated change?
It's documented in the change description though.
> graesslin wrote in xwindowtasksmodel.cpp:985
> QStringLiteral("...")
Done.
> graesslin wrote in xwindowtasksmodel.cpp:1005
> QStringLiteral
Done.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3292
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, graesslin, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
