graesslin added inline comments.
INLINE COMMENTS
> waylandtasksmodel.cpp:233-241
> + if (!appDataCache.contains(window)) {
> + const AppData &data = appDataFromAppId(window->appId());
> +
> + appDataCache.insert(window, data);
> +
> + return data;
> + }
here you are iterating twice over the cache: once for the contains, once for
the value.
Maybe do something like:
auto it = appDataCache.constFind(window);
if (it != addDataCache.end()) {
return *it;
}
const AppData &data = appDataFromAppId(window->appId());
appDataCache.insert(window, data);
return data;
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3292
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, graesslin, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
