graesslin added inline comments.
INLINE COMMENTS
> launchertasksmodel.cpp:134
> + const AppData &data = appDataFromUrl(url,
> QIcon::fromTheme(QLatin1String("unknown")));
> +
> + appDataCache.insert(url, data);
nitpick: added newline
> tasktools.cpp:145
> +
> + if (data.id.endsWith(".desktop")) {
> + data.id = data.id.left(data.id.length() - 8);
QLatin1String
> xwindowtasksmodel.cpp:984
> + if (!data.id.isEmpty()) {
> +
> KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" + data.id),
> + "org.kde.libtaskmanager");
this looks like an unrelated change?
> xwindowtasksmodel.cpp:985
> +
> KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" + data.id),
> + "org.kde.libtaskmanager");
> + }
QStringLiteral("...")
> xwindowtasksmodel.cpp:1005
> + KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" +
> service->storageId()),
> + "org.kde.libtaskmanager");
> }
QStringLiteral
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3292
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, graesslin, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
