graesslin added inline comments. INLINE COMMENTS
> sebas wrote in effects.h:239 > EffectWindow* ? Please check the coding style. There is supposed to be a space before * and &. See both Qt style https://wiki.qt.io/Qt_Coding_Style: "For pointers or references, always use a single space between the type and '*' or '&', but no space between the '*' or '&' and the variable name: " Example: // Wrong char* blockOfMemory = (char* ) malloc(data.size()); // Correct char *blockOfMemory = reinterpret_cast<char *>(malloc(data.size())); And KDE coding style at https://community.kde.org/Policies/Kdelibs_Coding_Style reads: "For pointers or references, use a single space before '*' or '&', but not after" Unfortunately not with such a nice example as in Qt case. REPOSITORY rKWIN KWin BRANCH highlight-windows-through-effects REVISION DETAIL https://phabricator.kde.org/D2630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, sebas Cc: sebas, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts
