graesslin added inline comments. INLINE COMMENTS
> luebking wrote in effects.cpp:1560 > Errr... wut? > Any reason to not *demand* some sort of soft API (slot signature) instead of > digging for the next best thing that remotely looks like the right thing? > > Maybe provide hard API like "Effect::performFeature(Feature f, QVariant v)"? Actually that was an experiment. I didn't want to use QMetaObject::invokeMethod with a string, so I wanted to try whether there's another way. But maybe adding another method is the better solution, it's not really beautiful code I wrote there. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
