luebking added inline comments.
INLINE COMMENTS
> effects.cpp:1560
> + const auto typeId = qMetaTypeId<QVector<KWin::EffectWindow*>>();
> + for (int i = 0; i < e->metaObject()->methodCount(); ++i) {
> + auto method = e->metaObject()->method(i);
Errr... wut?
Any reason to not *demand* some sort of soft API (slot signature) instead of
digging for the next best thing that remotely looks like the right thing?
Maybe provide hard API like "Effect::performFeature(Feature f, QVariant v)"?
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D2630
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas
