mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > volkov wrote in Printer.cpp:349 > From the Qt documentation ( https://doc.qt.io/qt-5/layout.html ): > "When you use a layout, you do not need to pass a parent when constructing > the child widgets. The layout will automatically reparent the widgets (using > QWidget::setParent()) so that they are children of the widget on which the > layout is installed." yep, that's correct, or alternatively to make it clearer, it works also the form QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Cancel, layout); that would add the widget to the layout and reparent it at the same time right upon creation REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1647 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, Plasma, mart Cc: mart, apol, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
