volkov added inline comments.

INLINE COMMENTS

> apol wrote in Printer.cpp:349
> Pass this as the last argument, so it has a parent and doesn't leak. On this 
> one and the rest of `new QDialogButtonBox`.

There is no need to set a parent in the constructor. QLayout::addWidget() will 
do it later.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1647

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma
Cc: apol, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to