volkov added inline comments. INLINE COMMENTS
> volkov wrote in Printer.cpp:349 > There is no need to set a parent in the constructor. QLayout::addWidget() > will do it later. >From the Qt documentation ( https://doc.qt.io/qt-5/layout.html ): "When you use a layout, you do not need to pass a parent when constructing the child widgets. The layout will automatically reparent the widgets (using QWidget::setParent()) so that they are children of the widget on which the layout is installed." REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1647 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, Plasma Cc: apol, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel