> On Dec. 3, 2015, 11:49 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateMacro.cmake, line 1 > > <https://git.reviewboard.kde.org/r/126185/diff/2/?file=418637#file418637line1> > > > > You might want to add documentation. > > > > You can get inspired with > > `kde-modules/KDEFrameworkCompilerSettings.cmake` or > > `modules/ECMInstallIcons.cmake`. Note it's also lacking the copyright > > header.
And you'll need to add a reference to the module to get Sphinx to find it - look at the files in docs/kde-module - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89097 ----------------------------------------------------------- On Dec. 3, 2015, 12:34 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126185/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 12:34 p.m.) > > > Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, > and Simon Wächter. > > > Repository: extra-cmake-modules > > > Description > ------- > > templates are very useful as teaching tool in order to make > a minimal application that uses a certain framework. > templates in the KAppTemplate repository will always get forgotten > (plus kapptemplate is not really necessary as they work in kdevelop as well) > An ideal situation would be frameworks having templates in their own repos > with templates of barebone apps using the main framework features. > In order to do that, the cmake stuff needed in order to correctly install > a template needs to be ported to a place avaiable to all frameworks > > > Diffs > ----- > > kde-modules/KDETemplateMacro.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126185/diff/ > > > Testing > ------- > > done some templates installed by plasma-framework > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
