----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review88896 -----------------------------------------------------------
`end*()` shouldn't have anything in the parenthesis. https://techbase.kde.org/Policies/CMake_Coding_Style - Aleix Pol Gonzalez On Nov. 27, 2015, 3:26 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126185/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 3:26 p.m.) > > > Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon > Wächter. > > > Repository: extra-cmake-modules > > > Description > ------- > > templates are very useful as teaching tool in order to make > a minimal application that uses a certain framework. > templates in the KAppTemplate repository will always get forgotten > (plus kapptemplate is not really necessary as they work in kdevelop as well) > An ideal situation would be frameworks having templates in their own repos > with templates of barebone apps using the main framework features. > In order to do that, the cmake stuff needed in order to correctly install > a template needs to be ported to a place avaiable to all frameworks > > > Diffs > ----- > > kde-modules/KDETemplateMacro.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126185/diff/ > > > Testing > ------- > > done some templates installed by plasma-framework > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
